[PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

[Dmitry Timoshkov]

Max TenEyck Woodbury <max at mtew.isa-geek.net> wrote:

> >> If you REALLY think the font should not load, you should add code to
> >> reject the font with an appropriate diagnostic, not have this code
> >> throw a divide by zero exception and abort execution.  Until you do
> >> that, this patch is needed.
> >
> > First, what is needed, is an investigation what is happening exactly,
> > that's what I asked about in the first place. If you belive that tmHeight
> > being 0 is normal and should be accepted, then you need to provide more
> > details and probably a test case.
> >
> Sorry, but that is not the case.  While an investigation would be
> useful, the question that it is normal or not is not relevant.  The
> simple fact is that it happens.  Since it DOES happen, the patch should
> be applied, at least until some code elsewhere assures that it can not
> happen.  If you want to throw in a 'FIXME' to the effect that it should
> not happen and a test is needed to assure that, by all means do so.

I wonder why did you bother with sending a patch at all? You don't want
to provide any details or do any investigation. With such an attitude
just open a bug report in bugzilla, and let somebody else do real work
for you, but even then you will be asked to provide at least some details.

-- 
Dmitry.