[PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

[Sam Edwards]

On 05/04/2013 08:27 PM, Max TenEyck Woodbury wrote:
> OK. Let's summarize:
>
> There are some fonts where tmHeight is in fact 0.  If Hin-Tak Leang is 
> correct, these may be Open-Source fonts possibly with proprietary 
> equivalents. Since I have hundreds of fonts installed on my system, it 
> is almost certain that I have one or more. Identifying which without 
> support in wine is a large task, not to be undertaken lightly.
>
Let's try to fully understand this problem and identify a font that 
causes the issue. Since you already have one installed in your font 
library, you could just run the tests with the attached patch applied 
and make quick work of identifying the troublesome font. Maybe 
(hopefully) it's an easy font to obtain so all of us can get a better 
look at what's going on.

I'm going to *guess* that tmHeight being 0 is the actual problem, but we 
won't know until we try the same font on Windows and see what Windows 
does. If Windows also produces tmHeight=0, then this patch makes perfect 
sense.

If Windows gives a non-zero tmHeight under the same circumstances, then 
we know the problem is in the font loader, and we'll fix that instead, 
thus making this patch unnecessary because tmHeight will always be 
nonzero anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdi32-HACK-Print-which-font-is-causing-division-by-z.patch
Type: text/x-patch
Size: 1008 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130504/cd85a4b6/attachment.bin>