[PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.

Erich E. Hoover erich.e.hoover at gmail.com
Mon May 13 07:18:38 CDT 2013


On Mon, May 13, 2013 at 3:45 AM, Hans Leidekker <hans at codeweavers.com> wrote:
> ...
>
> I don't see why you're still using these defines. It's unlikely that this code
> will work if NETLINK_ROUTE is defined but RTMGRP_IPV4_IFADDR isn't, for example.
>
> If there are versions of the netlink headers that don't have all of them it
> may be possible to work around that (e.g. by defining them ourselves), if not
> we can expand the configure check.

I was just trying to use the defines that were in each section of
code, since that's generally what I've seen in other places in Wine.
I'm happy to standardize on NETLINK_ROUTE though, as I'm unaware of
any issues with these features being unavailable in different versions
of the headers.  As soon as I get a chance I'll update that and
resubmit, thanks for all your help!

Best,
Erich



More information about the wine-devel mailing list