msvcrt: remove hack

[Christian Costa]

Le 30/05/2013 09:54, Marcus Meissner a écrit :
> On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote:
>> This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b
>>
>> but clang doesn't like it:
>> clang -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__
>> -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
>> -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers
>> -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith
>> -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer  -g -O2  -o process.o
>> process.c
>> process.c:363:10: warning: explicitly assigning a variable of type
>> 'int' to itself [-Wself-assign]
>>    action = action; /* Remove warning */
>>    ~~~~~~ ^ ~~~~~~
>> 1 warning generated.
>>
>> and no modern gcc/other compiler that I can find cares.
> It was probably added because of a tool that warned of the unused
> parameter ... So it all goes in circles. ;)
>
> Ciao, Marcus
>
>
>
So what about action = NULL instead?