d3d9/tests: add check for D3DFMT_V8U8 support to avoid possible test crash.

Stefan Dösinger stefandoesinger at gmail.com
Sat Nov 2 16:36:28 CDT 2013


On which GPU does that occur? Pixel Shader 1.x mandates V8U8 support afaik, so I am surprised this happens. I’m not opposed to this change conceptually though.

> +    IDirect3D9_Release(d3d9);
> +    if(FAILED(hr)) {
> +        skip("D3DFMT_V8U8 not supported\n");
> +        return;
> +    }
Please watch the formatting. Add a space between if and (, and put the { on the next line. Yeah, I know, the existing code isn’t quite consistent :-( .

Am 02.11.2013 um 07:23 schrieb Alexander Dorofeyev <alexd4 at inbox.lv>:

> ---
> dlls/d3d9/tests/visual.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> 
> 
> <0002-d3d9-tests-add-check-for-D3DFMT_V8U8-support-to-avoid-.txt>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20131102/0cdeef88/attachment.pgp>


More information about the wine-devel mailing list