urlmon: Compile tests with -D__WINESRC__.

Dmitry Timoshkov dmitry at baikal.ru
Mon Nov 11 09:39:39 CST 2013


Alexandre Julliard <julliard at winehq.org> wrote:

> >> >> >> > Please don't use lstrlenA in the tests.
> >> >> >> 
> >> >> >> Dmitry, could you please elaborate more on that?
> >> >> >
> >> >> > It hides the bugs.
> >> >> 
> >> >> Not with -D__WINESRC__.
> >> >
> >> > PSDK or mingw headers don't have an idea about __WINESRC__.
> >> 
> >> Yes but it can't possibly hide bugs, since all tests will be built and
> >> tested with the Wine headers too.
> >
> > I don't follow, it wouldn't hide bugs only if the tests would be built and
> > tested *without* the Wine headers too.
> 
> What hides bugs is the exception handler in lstrlen. When the tests are
> built with Wine headers, there's no exception handler, so it will crash
> and the bug will be caught. The only way a bug could remain hidden is if
> no one ever builds that test with Wine headers, which is not realistic.

That's correct, but it would be much better IMO to avoid any possible
difference in the generated test binaries with different compilers and
header sets. That's why any hidden dependency on __WINESRC__ on any other
Wine specific things in headers should be avoided as much as possible.

-- 
Dmitry.



More information about the wine-devel mailing list