Potential miss usage of strchr VS strrchr in Wine (was: [PATCH] wscript: Get extension name by strrchrW instead of strchrW.)

Hans Leidekker hans at codeweavers.com
Wed Nov 13 04:31:52 CST 2013


On Wed, 2013-11-13 at 18:00 +0800, Qian Hong wrote:
> While working on a vbscript bug affects a real world app, I found a
> potential miss usage of strchr/strrch in Wine. Here is a unfiltered
> list:
> 
> $ git grep "= strchr" | grep ext | grep -E "'\.'"
...
> dlls/msi/action.c:    extension = strchrW( filename, '.' );

This should be strrchrW.





More information about the wine-devel mailing list