[PATCH] ddraw: fill dwNumFourCCCodes in ddraw7_GetCaps

Henri Verbeet hverbeet at gmail.com
Thu Nov 14 11:26:36 CST 2013


On 14 November 2013 17:17, Patrick Rudolph <siro at das-labor.org> wrote:
>      hr = IDirectDraw7_GetAvailableVidMem(iface, &ddscaps, &caps.dwVidMemTotal, &caps.dwVidMemFree);
> -    wined3d_mutex_unlock();
>     if(FAILED(hr)) {
>         WARN("IDirectDraw7::GetAvailableVidMem failed\n");
>         return hr;
>     }
You now fail to release the mutex on the error path. Wrt. style, I
realize ddraw isn't entirely consistent about this, but you'll want to
put a space between the "if" and the '(', and but the '{' on a new
line.



More information about the wine-devel mailing list