shell32/tests: delete a nonexistent file in an existent dir or a nonexistent dir

Nikolay Sivov bunglehead at gmail.com
Mon Nov 18 11:13:36 CST 2013


On 11/18/2013 20:12, Zhenbo Li wrote:
> I found that shell32 test hasn't covered DE_INVALIDFILES
> ---
>  dlls/shell32/tests/shlfileop.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> +    ret = SHFileOperationA(&shfo);
> +    todo_wine
> +    ok(ret == 1026 ||
> +       ret == ERROR_FILE_NOT_FOUND || /* Vista */
> +       broken(ret == ERROR_SUCCESS), /* NT4 */
> +       "Expected 1026 or ERROR_FILE_NOT_FOUND, got %d\n", ret);
I think it's safe to mark XP result broken() as well. Also please use 
0x402 value here for it,
it's easier to find this way.



More information about the wine-devel mailing list