shell32/tests: Change Dec to Hex

Nikolay Sivov bunglehead at gmail.com
Tue Nov 19 12:16:34 CST 2013


On 11/19/2013 22:11, Alexandre Julliard wrote:
> Bruno Jesus <00cpxxx at gmail.com> writes:
>
>> On Tue, Nov 19, 2013 at 3:37 PM, Lauri Kenttä <lauri.kentta at gmail.com> wrote:
>>> On 2013-11-19 18:03, Zhenbo Li wrote:
>>>> +       "Expected 0x402 or ERROR_FILE_NOT_FOUND, got %d\n", retval);
>>>
>>> You should probably change the %d to %x, too.
>>>
>>> On the other hand, I don't see any need for your patch whatsoever. Maybe you
>>> should explain yourself.
>> Nikolay asked him:
>> http://wine.1045685.n5.nabble.com/Re-shell32-tests-delete-a-nonexistent-file-in-an-existent-dir-or-a-nonexistent-dir-td5777683.html
> Actually for Win32 error codes, decimal is preferable, that's how they
> are listed in winerror.h.
>
That was a special one, 0x402 is listed on msdn page only as 'unknown 
error', it's not a part of winerror.h, at least not in a recent 
versions. Anyway I don't think it makes sense to have a separate patch 
for that, I only mentioned it as one possible change to newly added 
tests. Of course it's not important to begin with.



More information about the wine-devel mailing list