[PATCH 3/5] wined3d: Get rid of surface_set_dirty().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-11-25 17:31, schrieb Stefan Dösinger:
> Am 2013-11-25 17:16, schrieb Henri Verbeet:
>> Actually, would that do that right thing if the application
>> first calls AddDirtyRect(), and then LockRect() with
>> D3DLOCK_DISCARD | D3DLOCK_NO_DIRTY_UPDATE?
> Good question. It obviously needs a test, but I think yes because
> only SYSMEM and DEFAULT pool surfaces support D3DLOCK_DISCARD, and
> I expect that D3DLOCK_NO_DIRTY_UPDATE is ignored on DEFAULT pool
> surfaces and on SYSMEM surfaces it has a different meaning.
That said, I don't think you even need D3DLOCK_DISCARD here.
AddDirtyRect on a managed texture followed by a
D3DLOCK_NO_DIRTY_UPDATE map is enough to cause trouble for my proposal.

I still recommend a test. Native d3d9 may ignore AddDirtyRect in this
case for a similar reason.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSk30xAAoJEN0/YqbEcdMwGlIP/2w8MZNzxUCtG3pqLjQasXie
Rk8NqYYRKcJIJZRudZnu6b7Tdxpj4yKnYyp93rSsUBQY1xV76ePCZs0puePOfkdc
T9TwV8Rn5jp2Y2IX1xMSQeqoFSyZUPhZ1vr+289CZ2Mp04cofhTuTc2trqmhbciH
j5XJFjt6yYvoldh77h7mrtRMXic5iKe9SmQRvV6zfzY3NNMFMuWLVVwxQvcu+ulr
jFydDi4HU6kF/pv4OOLVDsjy24DeDV3kL0G0XREN6ixWs41Fci7y09B8amUBne92
zmiARdzAUZ7ZvOq+pPmADrAEmZQy7uwWd4vKD/49UhDVpTRPrYhfjNw9Y+NdfGuX
zOPfMXXjGwV7cv1cGH2AKMj8FNJSU0OgoINlpnB3b/VmOTuheXzgL4HIm7pr3AK2
HeK/hGWrDjAS7BG/7CsCi5CW/lsXbeanh0zNZA/1AhKMQp3w0HM9AZp5/Ty8XFaM
BWPEqb8TseimVl4DH/mrHoKNptMuvpr/hTG82yVAaSEzshbRXEeeMXDp55RjACGJ
7Ux5DRf19aDj1GNl1lTlMO5X0HqjSY5cqn9zdAqk1fajt7qTPT4ux4A0Xqe7riXa
YBylEEQPl8gZCFPf1uVA1F5YP5KeL7VrG/VpBX+7dGMCBT+Z4jjGWF6/Fg+VHwtO
SljmdECQV+XsEOYcu6L7
=rgSe
-----END PGP SIGNATURE-----