winhttp/tests: Use BOOL type where appropriate

Bruno Jesus 00cpxxx at gmail.com
Wed Nov 27 05:18:11 CST 2013


On Wed, Nov 27, 2013 at 6:16 AM, Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> Frédéric Delanoy <frederic.delanoy at gmail.com> wrote:
>
>> --- a/dlls/winhttp/tests/notification.c
>> +++ b/dlls/winhttp/tests/notification.c
>> @@ -44,9 +44,9 @@ struct notification
>>  {
>>      enum api function;      /* api responsible for notification */
>>      unsigned int status;    /* status received */
>> -    int todo;
>> -    int ignore;
>> -    int skipped_for_proxy;
>> +    BOOL todo;
>> +    BOOL ignore;
>> +    BOOL skipped_for_proxy;
>
> Do you realize that BOOL is typedef'ed to int and therefore your patches
> do basically nothing? Is there any real reason behind these patches?

Hi, Dmitry. This has been discussed before, here is an example:
http://osdir.com/ml/wine-devel/2013-10/msg00131.html

> --
> Dmitry.

Best wishes,
Bruno



More information about the wine-devel mailing list