winhttp/tests: Use BOOL type where appropriate

Michael Stefaniuc mstefani at redhat.com
Wed Nov 27 06:24:47 CST 2013


On 11/27/2013 12:52 PM, Dmitry Timoshkov wrote:
> Bruno Jesus <00cpxxx at gmail.com> wrote:
> 
>>>> --- a/dlls/winhttp/tests/notification.c
>>>> +++ b/dlls/winhttp/tests/notification.c
>>>> @@ -44,9 +44,9 @@ struct notification
>>>>  {
>>>>      enum api function;      /* api responsible for notification */
>>>>      unsigned int status;    /* status received */
>>>> -    int todo;
>>>> -    int ignore;
>>>> -    int skipped_for_proxy;
>>>> +    BOOL todo;
>>>> +    BOOL ignore;
>>>> +    BOOL skipped_for_proxy;
>>>
>>> Do you realize that BOOL is typedef'ed to int and therefore your patches
>>> do basically nothing? Is there any real reason behind these patches?
>>
>> Hi, Dmitry. This has been discussed before, here is an example:
>> http://osdir.com/ml/wine-devel/2013-10/msg00131.html
> 
> I don't think that qualifies as a "discussion" :) Besides the using
> Windows-only BOOL type these patches break the git history and don't
> add any advertized clarity IMHO.
Again this is an optimization for the human reader. BOOL, TRUE and FALSE
make it easier to read the code without needing too much context.

But it isn't restricted to that. Other tools can do more strict checks
like warning about questionable opertations like arithmetic operations
with BOOLs. Even before Frederic started I've stumbled over Wine code
doing exactly that (oleaut32 in VarFormatNumber()) but the respective
code is "ugly" so I couldn't force myself to rewrite it and get rid of
the issue.

bye
	michael



More information about the wine-devel mailing list