winhttp/tests: Use BOOL type where appropriate

Dmitry Timoshkov dmitry at baikal.ru
Wed Nov 27 06:43:10 CST 2013


Michael Stefaniuc <mstefani at redhat.com> wrote:

> >>>> --- a/dlls/winhttp/tests/notification.c
> >>>> +++ b/dlls/winhttp/tests/notification.c
> >>>> @@ -44,9 +44,9 @@ struct notification
> >>>>  {
> >>>>      enum api function;      /* api responsible for notification */
> >>>>      unsigned int status;    /* status received */
> >>>> -    int todo;
> >>>> -    int ignore;
> >>>> -    int skipped_for_proxy;
> >>>> +    BOOL todo;
> >>>> +    BOOL ignore;
> >>>> +    BOOL skipped_for_proxy;
> >>>
> >>> Do you realize that BOOL is typedef'ed to int and therefore your patches
> >>> do basically nothing? Is there any real reason behind these patches?
> >>
> >> Hi, Dmitry. This has been discussed before, here is an example:
> >> http://osdir.com/ml/wine-devel/2013-10/msg00131.html
> > 
> > I don't think that qualifies as a "discussion" :) Besides the using
> > Windows-only BOOL type these patches break the git history and don't
> > add any advertized clarity IMHO.
> Again this is an optimization for the human reader. BOOL, TRUE and FALSE
> make it easier to read the code without needing too much context.

Is breaking git history really justified with this kind of patches?
Isn't this from the same (or close enough) area as changing hungarian
notation or replacing LP(C)STR by (const) char * on the whole Wine code
base?

-- 
Dmitry.



More information about the wine-devel mailing list