[PATCH 3/3] opengl32: Use opengl xml registry files.
Rico Schüller
kgbricola at web.de
Thu Oct 31 05:16:49 CDT 2013
On 29.10.2013 13:10, Alexandre Julliard wrote:
> Rico Schüller <kgbricola at web.de> writes:
>
>> ---
>> dlls/opengl32/make_opengl | 316
>> +++++++++++++++++++---------------------------
>> dlls/winemac.drv/opengl.c | 8 +-
>> dlls/winex11.drv/opengl.c | 8 +-
>> 3 Dateien geändert, 136 Zeilen hinzugefügt(+), 196 Zeilen entfernt(-)
>
> It's not generating quite the same thing as the previous version, and
> some of the differences look wrong, for instance:
>
> -static void WINAPI glBindAttribLocation( GLuint program, GLuint index, const GLchar* name ) {
> +static void WINAPI glBindAttribLocation( GLhandleARB programObj, GLuint index, const GLcharARB* name ) {
>
Yes, they look wrong. Apparently the alias did this. It's fine, when the
alias is ignored. I missed this, sorry. This could be fixed.
I found some other issues and now I think the xml seems not use able for
us in the state it is now. Sorry for the noise.
E.g. glColorSubTable is listed in the extension GL_ARB_imaging, but not
as GL 1.2 requirement. All linux drivers support at least 1.2 (and thus
don't expose GL_ARB_imaging), so there is no way to tell if we should
support that function or not. We would need a separate list for that ...
Imho this works for glBlendColor which is in GL_ARB_imaging and
GL_VERSION_1_4, but this seems also wrong as it should be in GL 1.2.
Did I miss anything?
Maybe we should provide a list which extension is part of which opengl
version?
Cheers
Rico
More information about the wine-devel
mailing list