[PATCH] kernel32: use ANSI code page if current thread locale is invalid

Dmitry Timoshkov dmitry at baikal.ru
Thu Oct 31 20:22:29 CDT 2013


Daniel Lehman <dlehman at esri.com> wrote:

>      case CP_THREAD_ACP:
> -        if (NtCurrentTeb()->CurrentLocale == GetUserDefaultLCID()) return ansi_cptable;
> +        if (!IsValidCodePage(NtCurrentTeb()->CurrentLocale) ||
> +            NtCurrentTeb()->CurrentLocale == GetUserDefaultLCID()) return ansi_cptable;

Please change the checks order, so that a valid locale doesn't need
to go through IsValidCodePage(). Also the check needs to be fixed,
locale id is not a codepage.

-- 
Dmitry.



More information about the wine-devel mailing list