[PATCH 3/5] wined3d: Don't clamp texture lookups in the GLSL fixed function fragment pipe.

Stefan Dösinger stefandoesinger at gmail.com
Tue Sep 3 06:31:14 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-09-03 09:47, schrieb Henri Verbeet:
> This originally came from the ARB fragment program implementation,
> but I don't see a justification for clamping there either. For the
> texture formats typically used with the fixed function pipe
> clamping wouldn't make a difference, and we don't have any tests
> that say we need to clamp.
The idea behind the clamps is that the fixed function pipeline is
generally limited to the [0.0;1.0] range. bbf313e7 added a test for
that, and there was e.g. 14706 (which doesn't contain much info tbh).

Personally I'd keep the clamps in unless a test says otherwise or
there's another compelling reason to remove them. But since it is
quite unlikely to matter that's not a strong opinion. The ideal
solution is of course to write a test.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSJciCAAoJEN0/YqbEcdMwQ2gP/Ayrnyv1b7VmviOCBLdKpW3P
YjEgLSFtaiEMGjJ6DD3iTLTRBaMOWZIryKyXdE5QLecKx35xuk6GbC+OAXgCCZfU
a558nJwymMtMpiU9Wa2nuUXF4p+KuC8CHkCgfOGF1D4wDZcQQxfEcvKcwAGPaZwV
PWiKKI8SWO69XlawZHOLyWz97gghYpLrHIexOxbCVXGMXee7pqAQTSz2oRVppHot
39T2qbFo21qtoyK7sgqMgnRko52eiJGSBVHCfcfhhMPh+mksQvPoZDcdK/KSAl6r
K5Py0kbVjBDjE9I6uCGO9+bt6a6RrJpC/6JGIOypDvicnjd/7X4LK8SYfGv3Cvr6
qejlsAouxrQgdYARrdjnoR4IEK8WviBzOZDnvxOS8dlEsJxjMjxIScnemdNacNKO
QY3DJ/GmfnsnOXnrrvADKkLvCkeIUCE5v6U9Kv+S9GsMgNeJs1IEHzQpROBmt/iO
ukUH+aOe4JReH1mtynrX+GsjwZkDPzatx48SxOOopWW5akiCbEsJNFirR4m1St9E
5+iOCkGQkjWVz95XgZt3VRpUBxx12JHsX1/UscBmprvkutmbUOYvRIpgqdTyZknD
dW4x79KWQ6YUu3k8Lho8EfChR8rzPoDeaHwclY/WrwE+yuHugk+z0dv/gclC3eiL
HAQ0T8GuuElJvdPfgE3F
=8XAf
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list