ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

Bruno Jesus 00cpxxx at gmail.com
Tue Sep 3 13:37:29 CDT 2013


On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard <julliard at winehq.org> wrote:
> Bruno Jesus <00cpxxx at gmail.com> writes:
>
>> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cpxxx at gmail.com> wrote:
>>> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard <julliard at winehq.org> wrote:
>>>> Bruno Jesus <00cpxxx at gmail.com> writes:
>>>>
>>>>> try 2:
>>>>> Narrow the loop for the specified protocol
>>>>> Add a new test for invalid sockets
>>>>
>>>> Considering what WSAEnumProtocols does, the loop doesn't seem necessary
>>>> at all.
>>>
>>> It will when WSAEnumProtocols return AF_INET6 data =)
>>
>> Will you find more reasonable to "unstatic"
>> WINSOCK_EnterSingleProtocolW from protocol.c, add a family parameter
>> to it and use it inside socket.c ?
>
> Yes, though moving it all to socket.c is probably cleaner. We don't need
> a separate file for just that one API.

You mean removing protocol.c and adding all content to socket.c? If
yes I would appreciate if you could do that because I don't have the
git skills and wouldn't now how to sort the functions inside socket.c.

> --
> Alexandre Julliard
> julliard at winehq.org



More information about the wine-devel mailing list