[PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Dmitry Timoshkov dmitry at baikal.ru
Thu Sep 5 04:55:55 CDT 2013


Wolfgang Walter <wine at stwm.de> wrote:

> > > > > +    if (res || (!res && GetLastError() == ERROR_IO_PENDING))
> > > > > +        /* if data has been sent: wait for termination */
> > > > > +        Sleep(timeout);
> > > > 
> > > > I don't see such a problem with real COM-port and serial-USB cable
> > > > under Windows or Linux here and under testbot VMs.
> > > 
> > > Wine does that here (vanilla). I added this so that the NEXT test does not
> > > depend what wine exactly does.
> > 
> > When Wine behaviour differs from Windows one the test results need to be
> > marked as todo_wine, and such places already have it.
> 
> I don't unterstand you. I didn't change the test case. It still above and is 
> still marked with todo.

There is no need to add any workarounds for Wine bugs, appropriate places
already have todo_wine statements.

-- 
Dmitry.



More information about the wine-devel mailing list