[PATCH 1/6] riched20: Implement ITextDocument_fnOpen.

Alexandre Julliard julliard at winehq.org
Thu Sep 26 13:09:18 CDT 2013


Jactry <jactry92 at gmail.com> writes:

> +    chBuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size+2);
> +    if(!chBuffer)
> +    {
> +        CloseHandle(hFile);
> +        return HRESULT_FROM_WIN32(GetLastError());
> +    }

It's not useful to zero the buffer since you are reading into it. Also
GetLastError won't do anything useful here.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list