[PATCH] ddraw: add dsurface dimension tests, try 7

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Thanks for the patch. I'll test it on my Windows boxes as soon as
they're done with Linux updates (Gentoo...) and report any failures I
find.

Am 2014-04-03 17:54, schrieb Patrick Rudolph:
+    window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW,
+            100, 100, 160, 160, NULL, NULL, NULL, NULL);
+
+    if (!(ddraw = create_ddraw()))
+    {
+        skip("Failed to create a ddraw object, skipping test.\n");
+        return;
+    }
You no longer need the skip check here. The main functions in
ddraw1-ddraw7 check if ddraw creation succeeds and skip all tests if
it doesn't

+
+    ret = IDirectDraw_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL);
+
+    ddcaps.dwSize = sizeof(DDCAPS);
You're not checking the return value here. I also recommend to rename
"ret" to "hr" for consistency with other tests.

+    ret = IDirectDraw_GetCaps(ddraw, &ddcaps, NULL);
+    if (ret != DD_OK)
+    {
+        skip("IDirectDraw_GetCaps failed with %08x\n", ret);
+        return;
+    }
Do you have hardware where GetCaps fails? If not, a simple
ok(SUCCEEDED(hr), ...) should be enough.

+#if _WIN64 || __x86_64__ || __ppc64__
+    {
+        MEMORYSTATUSEX statex;
+        statex.dwLength = sizeof (statex);
+        GlobalMemoryStatusEx (&statex);
+        /* on 64bit surfaces with 2GByte+ are possible */
+        if(statex.ullAvailVirtual > 0x80000000LL)
+            tests[10].ret = DD_OK;
+    }
+#endif
Is the #if necessary? Afaics GlobalMemoryStatusEx should work on 32
bit as well. In light of the testbot failures I recommend to check for
available physical memory as well. I'm also fine with just dropping
the SYSMEM out of memory test until we find an application that
depends on this behavior.

The parenthesis placement after the function call and if are
inconsistent. This applies to a few other ifs as well.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTPmKGAAoJEN0/YqbEcdMwUwEP/A5NCz4xe855Z9jX6iUBWkhw
NDhpM/9Wbk5tdekaR3QcrNyCYGCAHnOl/kUsGXeBDwZxCDzRzpfsdpFp0Nux46m+
L/xtf71bhAMYGikeV9r/C+UVBbCslO4KXFcUmx5K43AXcVQGMq+K1yvzhGtKCGZb
6zNCUmhxI2MlNrU9KDp7W7kNhVWMu2ungAjojT5BmaWDgtvS6TWu10jX1rIwQlYF
wMOHSIomIBNvPi2vSr8aXLzPhgFCrMg3g8fERUqS3Vk8LJfmJYWJ87hcfPiMGd5A
ntDYedg+mhV0ShTk26XCeKMNBfvjcdwWCnHEi1GYmYQ6H/nRDGxkEO/TskiNLuNn
IO/rV2TAO9SfzHzHO/VPCGdb6nISGICAP/oA2ryrhINdXtn6eq1kjqQsGUURlqlk
Y46P55qgRleYCtqxHjrjhQXDL4anaKj3ApZjGRa9MVC2/SPvIe3UpjlHjN4oeAix
ohiOiq7GL/PXXs0zLOKFeVdUoOYpCIuP7MsR/dX9KcJwYQ2U9GT6OEoQPhZT+/B7
Tpv1maEOnn+UCkvcW6BY2eAt3nsznvlKVb73D5t1tLp/LCbKiSqY+8Dk0f75YTyG
hEXkawRFLjhXeA6db8ieb2GdftaAnfq1Vxa7wjF4igAccZIhySInrvdnOFhZ4rp+
djHZm23O6ml1uV8Qt0mW
=yrSd
-----END PGP SIGNATURE-----