dpnet: Improve Error checking in Get/Set SP (try 4)

Stefan Dösinger stefandoesinger at gmail.com
Thu Apr 10 02:26:43 CDT 2014


Am 10.04.2014 um 09:18 schrieb Stefan Dösinger <stefandoesinger at gmail.com>:
> You shouldn’t have to set client->init = FALSE because you allocate client with HEAP_ZERO_MEMORY. If you prefer to set it for clarity that’s ok with me.
> 
> The same applies to SP_guid, for two reasons: First, it’s already initialized to zeroes, and you’re not reading it unless client->init is set to TRUE, which only happens after a successful SetSP call.
> 
> IMHO you can also correct the indentation in this function, but I’ll leave the decision up to you.
To clarify: Only change the indentation when you change something else in the function.

/me blames the accidental wine-patches CC on Apple Mail…

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20140410/243b634b/attachment.sig>


More information about the wine-devel mailing list