[2/2]wmvcore: add WMMetadataEditor stub implementation - Try 3
Dmitry Timoshkov
dmitry at baikal.ru
Sat Apr 12 00:12:59 CDT 2014
Qian Hong <fracting at gmail.com> wrote:
> >> +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface)
> >> +{
> >> + WMMetadataEditor *This = impl_from_IWMMetadataEditor(iface);
> >> + FIXME("(%p)\n", iface);
> >> + heap_free(This);
> >> + return S_OK;
> >> +}
> >
> > Why not pass 'This' to WMCreateEditor_close() directly? Why a FIXME?
> > There is still a stray empty line after WMCreateEditor().
> >
>
> I think it is correct to pass 'iface' to WMCreateEditor_close, which
> is a public interface:
> http://msdn.microsoft.com/en-us/library/windows/desktop/dd757235(v=vs.85).aspx
Well, I had an impression that it's just an internal helper, thanks
for the clarification. In that case freeing the implementation looks
wrong.
--
Dmitry.
More information about the wine-devel
mailing list