[2/2]wmvcore: add WMMetadataEditor stub implementation - Try 3
Nikolay Sivov
bunglehead at gmail.com
Sat Apr 12 01:48:14 CDT 2014
On 4/12/2014 07:33, Jeff Latimer wrote:
> +static const IWMMetadataEditorVtbl VT_Editor = {
> + WMCreateEditor_QueryInterface,
> + WMCreateEditor_AddRef,
> + WMCreateEditor_Release,
> + WMCreateEditor_open,
> + WMCreateEditor_flush,
> + WMCreateEditor_close
> +};
Please use better naming, for method prefix it could be
WMMetadataEditor_, for vtable - WMMetadataEditorVtbl.
> +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface)
All these should be static.
> HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor)
> {
> - FIXME("(%p): stub\n", editor);
> + WMMetadataEditor *metadata_editor;
> + TRACE("(%p)\n", editor);
>
> - *editor = NULL;
You're removing important like for out pointer initialization.
More information about the wine-devel
mailing list