[PATCH 3/4] oleacc: Add ObjectFromLresult implementation

Piotr Caban piotr.caban at gmail.com
Fri Apr 25 07:12:03 CDT 2014


On 04/25/14 14:02, Dmitry Timoshkov wrote:
> Piotr Caban <piotr.caban at gmail.com> wrote:
>
>> On 04/25/14 13:34, Qian Hong wrote:
>>> +    atom = result;
>>> +    if(atom != result)
>>> +        return E_FAIL;
>>>
>>> I can't understand these few lines, are they typo or did I miss anything?
>> result and atom has different size. This code checks if LRESULT
>> describes atom or error.
>
> GlobalGetAtomNameW should handle this just fine, 'atom' is a misleading
> intermediate variable IMO.
>
No, it's not handling it. It can happen that cast from an error code is 
a valid atom.



More information about the wine-devel mailing list