mshtml: Added IHTMLTable::width property implementation. (try 5)
Jacek Caban
jacek at codeweavers.com
Mon Apr 28 03:38:41 CDT 2014
Hi Zhenbo,
This looks better, but there are two more things I didn't catch earlier.
On 04/27/14 15:08, Zhenbo Li wrote:
> + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val);
> + if (NS_FAILED(nsres)){
> + ERR("Get Width(%s) failed!\n", debugstr_variant(p));
You can't access output argument (p) here. This will be undefined.
> + nsAString_Finish(&val);
> + return E_FAIL;
> + }
> +
> + hres = nsstr_to_truncated_bstr(&val, &bstr);
> +
> + V_VT(p) = VT_BSTR;
> + V_BSTR(p) = bstr;
> + return hres;
You leak val here.
Jacek
More information about the wine-devel
mailing list