[PATCH] shell32/tests: Remove some assertions in test code

Nikolay Sivov nsivov at codeweavers.com
Wed Feb 5 08:50:39 CST 2014


On 2/5/2014 15:09, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://newtestbot.winehq.org/JobDetails.pl?Key=4602
>
> Your paranoid android.
>
>
> === wxppro (32 bit shlexec) ===
> shlexec.c:1204: Test failed: expected 1 args, got 4
> shlexec.c:2247: Test failed: argcA expected 5, but got 4
>
> === w2008s64 (32 bit shlexec) ===
> shlexec.c:1545: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt28F.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test file.shlexec'
> shlexec.c:2623: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt28F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test2.exe'
> shlexec.c:2636: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt28F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test2.exe'
> shlexec.c:2648: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt28F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test2.exe'
>
> === w2008s64 (64 bit shlexec) ===
> shlexec.c:1545: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt176.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test file.shlexec'
> shlexec.c:2623: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt176.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test2.exe'
> shlexec.c:2636: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt176.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test2.exe'
> shlexec.c:2648: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt176.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test2.exe'
I don't think this has anything to do with my patch. Looks like some 
short/long path comparison, I'll try to fix some assertions first and 
then we'll see what happens to test results.



More information about the wine-devel mailing list