[PATCH v2 1/6] wined3d: Add support for NV12 textures

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi again!

I have some more format nitpicks below.

As far as the big picture is concerned there is also a software
conversion path in dlls/wined3d/surface.c. Search the file for
d3dfmt_converter_desc and you should find the right place. You don't
have to submit a patch for that unless you know an application that
needs it though; I'm just making you aware of it.

Am 2014-02-11 12:14, schrieb Martin Storsjo:
> +    switch(textype)
You're missing a space here. As far as I can see the other places in
this patch are correct, but it doesn't hurt to double-check with grep
or something.

(I really hope the testbot can one day take care of this...)

> +        case GL_TEXTURE_2D:             tex = "2D";     break;
Please make this
case GL_TEXTURE_2D:
    tex = "2D";
    break;

etc

> +     * When reading from rectangle textures, keep in mind that
> the input y coordinates +     * go from 0 to d3d_height, whereas
> the opengl texture height is 1.5 * d3d_height +     */
Comment closing should go next to the last line of text. Also add
proper interpunctuation at the last sentence of a comment.

This applies to a few more places in this patch, and most likely the
other patches.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS+4aPAAoJEN0/YqbEcdMwCXMQAIPeaYbrI+zC2zf6KlOdOCbe
yDSbSvRS4vZWkukemQCb6jr2qFCjqoCJMHj1GpfWxlBxJ1+rOWyTdc+YG2DDzCqk
YE3K8PgOaID7BnopA/Ri0gYiwRz7K2WBpMWMwgeVnjTFOUWJ8tYt1z4VmCHXgEEi
JDphv1q9IDzCW/s3Pu68VtDrE4rsG/KLietRPTCgakdjX1oLvlKn1Fg5D7q78y87
szJg2SRaYOVWSXIK2D+s+A5Tvjr9gffSsDE6fgFgxeFyHsViGyq6QDJEBxCO+f+A
UZ1FhidcogIt/sqSphg7lCyEUw49WojlXSXhLpdofwjrR/4griYgp21h6Y8UhtqG
LzPUVGBfScvb208bIhL+LvCukQ00WnTI4LJA6khjL9AlCnrzh4nrhVo6RQDrL1A3
6V5gJLd1ZT4DepQc2XQLC0FupgYWafIJAzCcpZIpvQRjzH4MqJgeJC9m6alRzyWr
TkN+Jo6yKRk2t+x7LOzee+mMPAfIT2OcHoIlG60Z8ZxK3Apu6k7/RPoqi1BWdJZZ
gHA1CZLUDC+UXhPhr2pxNy4AQnD2EbIBp5GPKNHHvoqJJzXvbHPBx5TgOOaEyLnH
idubGx+GLf3zXEaK+ujbMg8Ae/poGh841gBVbMLDqZguSkuTsVGpt8hjCZgWq+5d
u177zpoEIMhOFIK17nSY
=IHTQ
-----END PGP SIGNATURE-----