Fixing up the code style

Stefan Dösinger stefandoesinger at gmail.com
Thu Feb 13 07:09:26 CST 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

After recently helping two contributors (the Pipelight guys and Martin
Storsjö) through the maze of the Wine code style I think it's best to
lift the ban against style-only patches and unify the code style once
and for all.

The basic reasoning is that from my point of view the lack of clarity
wrt the code style and lack of automatic enforceability is causing
more issues than the problems style-only patches cause with git blame.
Finding a style-only change with git blame can be handled by running
git blame again. Frustrating contributors on the other hand has no
workaround.

So I propose to agree on a code style for the entire project, fixing
it up preferably with an automated tool and in the future enforcing
the style with checks in the Testbot.

Opinions?

Wrt the code style I propose the style that is used in wineserver. It
is the same one as the new style in the d3d code except for
single-line if conditions.

Cheers,
Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIbBAEBAgAGBQJS/MQGAAoJEN0/YqbEcdMw7rMP+LAP5pnxyy9onITtJVe8swuy
pKrS+U1NgLIru9yGuuxUsejUr8gY9hD27nSQQ2OddzSV3pEkY6vmqftSIFVT8Oli
d0kEXbxZhlzRe9rCgEJGLGx73ap/LBOm0k3jtslOVONlIyH8AXdEG37a2P7s8SKV
D9p0Sw7ggNRF8D0eIszSPKjfUfBYph+9XU1SDA9aEfokv6rs6AFt9xehCOUsdayZ
gwqiigg70tkez81GhDRfuXWVn6pdsVpeLDjxF4P2XFMT00OInJIYBIy2w91sxgOs
3vos4X60+qg+sIGxAhxgfLilVQSbBOqvBz9QEUycOduzJK87sVfGtpsipCX4qW1Z
QNE+SOINHjazNPB0mydO7s6rThOuZS2BU5nG+ZaXmbe5RBUXLMqqjUmIGL2ZYodJ
zQ+3eOHC0H8fxaNhqwpRh5Gq8fVE+xcXauovLv0Ro+FskOitfazIBJEfktjJuXZ8
YZcmLqQAGCwd0Y9pTOTXldoR9ah1+gO7ya5n2ljR0+viAol6KQoUaD4dFNhEur4j
cpmW2EDks/wPVrvjX2u8cphHGeOLSjDEErnE/PoX5w7jNarekRWSSalanYB+04SX
rjxUXSVq30upNdJ07W2L8gLaHTgHq0rglR1ZrSYEDw5FtaG/Xs4W0YqyX5APl/+O
Bj4qRaV70TNOicRNgaA=
=DQdS
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list