Fixing up the code style

[Sebastian Lackner]

Am 13.02.2014 15:24, schrieb Stefan Dösinger:
> Am 2014-02-13 14:57, schrieb Jacek Caban:
> Martin, Michael or Sebastian: If you are reading this thread maybe you
> can share your thoughts from the point of view of someone who isn't a
> long-term contributor.
> 

I have to agree with Stefan, for someone new trying to contribute to the
project its really confusing. Often not even inside a single DLL a
unique style is used, and especially tests are often even a bit worse.

When someone wants to contribute, he might just think that there isn't
any code style restriction at all. But even with the knowledge that
there is one, its sometimes not very clear what the rules are exactly.
Noone would start by creating statistics first, to figure out what the
most commonly used style is.

To sum it up, I would also support the idea to refactor the whole code base.

Several methods (ordered from best to worst):

* refactor the code globally, such that every component uses the same
style. This would be the easiest method for people to check their own
code, since they can just use a checktool on the whole wine source.

* at least a single code style for each DLL/component individually, and
someone who documents the used code style for every component if its not
obvious (like a header field or as part of the spec file?).

* as a last option, but very complicated, and most likely not worth the
effort: instead of refactoring Wine could provide some git precommit
hook / other check tool, to test patches if they match the rules for a
specific component

BTW: with "git blame -w" its not even necessary to run it twice ;)

Regards,
Sebastian