[PATCHv4 2/3] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting
Martin Storsjö
martin at martin.st
Mon Feb 17 06:29:14 CST 2014
On Mon, 17 Feb 2014, Bruno Jesus wrote:
> On Mon, Feb 17, 2014 at 9:21 AM, Martin Storsjö <martin at martin.st> wrote:
>>>> + if (desc)
>>>> + HeapFree(GetProcessHeap(), 0, desc);
>>>
>>> There's no point in checking for NULL before HeapFree().
>>
>>
>> MSDN says "If this pointer is NULL, the behavior is undefined" about the
>> lpMem parameter to HeapFree.
>
> Actually it does not matter what MSDN says in this case, the wine
> source code is very clear:
> http://source.winehq.org/source/dlls/ntdll/heap.c#L1740
Yes, but isn't the wined3d code supposed to be able to run on top of plain
windows as well, not only on top of wine?
// Martin
More information about the wine-devel
mailing list