dmime: Do not try to query a NULL direct sound buffer

Nikolay Sivov bunglehead at gmail.com
Wed Feb 26 03:11:22 CST 2014


On 2/26/2014 13:03, Aric Stewart wrote:
> ---
>   dlls/dmime/audiopath.c | 33 ++++++++++++++++++---------------
>   1 file changed, 18 insertions(+), 15 deletions(-)
Why is it NULL though? The only place I found that sets it is this:

---
     hr = IDirectSound8_CreateSoundBuffer ((LPDIRECTSOUND8) 
This->pDirectSound, &desc, &buffer, NULL);
     if (FAILED(hr)) {
             HeapFree(GetProcessHeap(), 0, default_path);
             *ppNewPath = NULL;
             return DSERR_BUFFERLOST;
     }
     default_path->pDSBuffer = buffer;
---

That means CreateSoundBuffer() doesn't return error code properly?



More information about the wine-devel mailing list