dmime: Do not try to query a NULL direct sound buffer

Aric Stewart aric at codeweavers.com
Fri Feb 28 01:10:02 CST 2014



On 2014/02/26 18:11, Nikolay Sivov wrote:
> On 2/26/2014 13:03, Aric Stewart wrote:
>> ---
>>   dlls/dmime/audiopath.c | 33 ++++++++++++++++++---------------
>>   1 file changed, 18 insertions(+), 15 deletions(-)
> Why is it NULL though? The only place I found that sets it is this:
> 
> ---
>      hr = IDirectSound8_CreateSoundBuffer ((LPDIRECTSOUND8) This->pDirectSound, &desc, &buffer, NULL);
>      if (FAILED(hr)) {
>              HeapFree(GetProcessHeap(), 0, default_path);
>              *ppNewPath = NULL;
>              return DSERR_BUFFERLOST;
>      }
>      default_path->pDSBuffer = buffer;
> ---
> 
> That means CreateSoundBuffer() doesn't return error code properly?
> 
> 

It is NULL because of Andrew's commit:

commit 629e857c2ee0e8816a11ee4ab446c13798362f33
Author: Andrew Eikum <aeikum at codeweavers.com>
Date:   Wed Apr 18 10:14:01 2012 -0500

    dmime: Don't try to create a standard audio path if the client didn't ask for one.



-aric



More information about the wine-devel mailing list