msi: Use BOOL type where appropriate

Hans Leidekker hans at codeweavers.com
Fri Feb 28 04:08:04 CST 2014


On Fri, 2014-02-28 at 10:35 +0100, Frédéric Delanoy wrote:
> diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h
> index 75d1920..62d69b2 100644
> --- a/dlls/msi/msipriv.h
> +++ b/dlls/msi/msipriv.h
> @@ -409,13 +409,13 @@ typedef struct tagMSIPACKAGE
>      struct list sourcelist_info;
>      struct list sourcelist_media;
>  
> -    unsigned char scheduled_action_running : 1;
> -    unsigned char commit_action_running : 1;
> -    unsigned char rollback_action_running : 1;
> -    unsigned char need_reboot_at_end : 1;
> -    unsigned char need_reboot_now : 1;
> -    unsigned char need_rollback : 1;
> -    unsigned char full_reinstall : 1;
> +    BOOL scheduled_action_running;
> +    BOOL commit_action_running;
> +    BOOL rollback_action_running;
> +    BOOL need_reboot_at_end;
> +    BOOL need_reboot_now;
> +    BOOL need_rollback;
> +    BOOL full_reinstall;
>  } MSIPACKAGE;
>  
>  typedef struct tagMSIPREVIEW
> @@ -486,10 +486,10 @@ typedef struct tagMSICOMPONENT
>      MSIASSEMBLY *assembly;
>      int num_clients;
>  
> -    unsigned int anyAbsent:1;
> -    unsigned int hasAdvertisedFeature:1;
> -    unsigned int hasLocalFeature:1;
> -    unsigned int hasSourceFeature:1;
> +    BOOL anyAbsent;
> +    BOOL hasAdvertisedFeature;
> +    BOOL hasLocalFeature;
> +    BOOL hasSourceFeature;
>  } MSICOMPONENT;
>  
>  typedef struct tagComponentList

I don't think it's worth the extra memory use here.





More information about the wine-devel mailing list