shell32/tests: Add test for SHGetPathFromIDListA

Zhenbo Li litimetal at gmail.com
Wed Jan 8 02:41:44 CST 2014


2014/1/8 Dmitry Timoshkov <dmitry at baikal.ru>:
>
>> +void test_SHGetPathFromIDListA(void)
>> +{
>> +    BOOL ret;
>> +    char pszPath[MAX_PATH];
>> +
>> +    ret = SHGetPathFromIDListA(NULL, pszPath);
>> +    ok(!ret, "SHGetPathFromIDListA should fail.\n");
>> +}
>
Thank you for reviewing my patch.

> 1. the test should be 'static'.
> 2. who is supposed to call this test?
Sorry, I've missed them.
> 3. it would be ineteresting to see whether the tested API should set
> an error code or somehow indicate a reason of the failure.
You're right. I'll check GetLastError() in my patch.

BTW, is putting such code in string.c a good idea?



-- 
Have a nice day!
Zhenbo Li



More information about the wine-devel mailing list