[PATCH 6/6] ddraw/tests: Add some color key tests for complex surfaces.

[Henri Verbeet]

On 9 January 2014 13:06, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2014-01-09 12:17, schrieb Henri Verbeet:
>> +    hr = IDirectDrawSurface7_GetAttachedSurface(surface, &caps,
>> &tmp); +    ok(SUCCEEDED(hr), "Failed to get attached surface, hr
>> %#x.\n", hr); +    hr = IDirectDrawSurface7_GetColorKey(tmp,
>> DDCKEY_SRCBLT, &color_key); +    ok(hr == DDERR_NOCOLORKEY, "Got
>> unexpected hr %#x, i %u.\n", hr, i); + +
>> color_key.dwColorSpaceLowValue = 0x0000ff00; +
>> color_key.dwColorSpaceHighValue = 0x0000ff00; +    hr =
>> IDirectDrawSurface7_SetColorKey(surface, DDCKEY_SRCBLT,
>> &color_key); +    ok(SUCCEEDED(hr), "Failed to set color key, hr
>> %#x.\n", hr); +    memset(&color_key, 0, sizeof(color_key)); +
>> hr = IDirectDrawSurface7_GetColorKey(surface, DDCKEY_SRCBLT,
>> &color_key); +    ok(SUCCEEDED(hr), "Failed to get color key, hr
>> %#x.\n", hr); +    ok(color_key.dwColorSpaceLowValue == 0x0000ff00,
>> "Got unexpected value 0x%08x.\n", +
>> color_key.dwColorSpaceLowValue); +
>> ok(color_key.dwColorSpaceHighValue == 0x0000ff00, "Got unexpected
>> value 0x%08x.\n", +            color_key.dwColorSpaceHighValue); +
>> +    IDirectDrawSurface_Release(tmp);
> Did you mean to call SetColorKey and GetColorKey on tmp instead of
> surface here?
>
I did, updated patch sent. As an aside, I've noticed this before, but
your MUA seems to have some issues with quoting.