[PATCH 6/6] wined3d: Do not warn about WINED3DUSAGE_WRITEONLY.

Henri Verbeet hverbeet at gmail.com
Thu Jun 5 05:40:56 CDT 2014


On 5 June 2014 12:32, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2014-06-04 19:21, schrieb Henri Verbeet:
>> I could imagine buffers being moved from VRAM to GART when they're
>> mapped, which would then make subsequent draws potentially slower.
>> Dynamic buffers are more or less expected to be in GART, but we
>> want static buffers to be in VRAM as much as possible. I could also
>> perhaps imagine the driver keeping a copy in CPU memory instead,
>> but that would then use up address space.
> I guess those things are possible, but at the moment hypothetical. I
> don't think we should keep printing the FIXME because of them. If we
> print anything it would be better to write a FIXME if DYNAMIC is set,
> but WRITEONLY isn't.
>
I suppose you could replace the current FIXME with some kind of
d3d_perf WARN in buffer_init(). I'd still prefer benchmarking about
the impact of the flag in various scenarios be done.



More information about the wine-devel mailing list