[PATCH 2/3] gdiplus: Set outer pointer to NULL when image loading functions fail.

Qian Hong qhong at codeweavers.com
Wed Mar 5 02:18:30 CST 2014


Hi Dmitry,

On Wed, Mar 5, 2014 at 3:49 PM, Dmitry Timoshkov <dmitry at baikal.ru> wrote:
>> Thanks very much for the advice, every comments have been addressed
>> and a try 2 has been sent. Wish you have a good day :)
>
> Of course it would be more interesting to test gdiplus image loading
> APIs on a real image file instead of a zero-sized one, probably then
> you wouldn't get NotImplemented in patch 3/3 either.

Thanks for your thought, but that not the point of my tests:
+    hfile = CreateFileW(non_shrW, GENERIC_READ, 0, NULL,
OPEN_EXISTING, FILE_FLAG_DELETE_ON_CLOSE, 0);
My point is to test a file without share-reading access, so
GdipCreateStreamOnFile is going to fail no matter if the file is empty
or not.




-- 
Regards,
Qian Hong

-
http://www.codeweavers.com



More information about the wine-devel mailing list