wintab: Incorrectly classifying cursor as stylus instead of eraser

Eriks Dobelis eriks.dobelis at biti.lv
Thu Mar 20 07:33:50 CDT 2014


Did not attach the patch in my last email :(

For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly 
detected as stylus.
The tablet returns its eraser cursor name as:
Wacom Intuos PT S Pen eraser
and type as:
ERASER

Current code classifies this as STYLUS, because name of the cursor 
contains the word 'Pen'. It is very unlikely that a cursor with type 
ERASER is STYLUS.

With the patch eraser is correctly detected. Without the patch eraser 
works as stylus.

  dlls/winex11.drv/wintab.c | 3 +++
  1 file changed, 3 insertions(+)

-------------- next part --------------
>From 183bfd0e9a2d0fd14f07658dc9dd259c4e4435fd Mon Sep 17 00:00:00 2001
From: Eriks Dobelis <eriks.dobelis at biti.lv>
Date: Thu, 20 Mar 2014 14:19:58 +0200
Subject: [PATCH 2/2] Classifying cursor as eraser if type is eraser

---
 dlls/winex11.drv/wintab.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/winex11.drv/wintab.c b/dlls/winex11.drv/wintab.c
index 23a5423..91d6498 100644
--- a/dlls/winex11.drv/wintab.c
+++ b/dlls/winex11.drv/wintab.c
@@ -426,6 +426,9 @@ static BOOL is_stylus(const char *name, const char *type)
         NULL
     };
 
+    if (type && match_token(type, "eraser"))
+        return FALSE;
+
     for (i=0; tablet_stylus_whitelist[i] != NULL; i++) {
         if (name && match_token(name, tablet_stylus_whitelist[i]))
             return TRUE;
-- 
1.8.3.2



More information about the wine-devel mailing list