[PATCH] gdi32: Add MS Shell Dlg tests

Dmitry Timoshkov dmitry at baikal.ru
Mon May 12 00:54:28 CDT 2014


Alex Henrie <alexhenrie24 at gmail.com> wrote:

> +    memset(&efnd, 0, sizeof(efnd));
> +    strcpy(lf.lfFaceName, "MS Shell Dlg");
> +    ret = EnumFontFamiliesExA(hdc, &lf, enum_fullname_data_proc, (LPARAM)&efnd, 0);
> +    ok(ret, "font MS Shell Dlg is not enumerated\n");
> +    ret = strcmp((char*)efnd.elf[0].elfLogFont.lfFaceName, "MS Shell Dlg");
> +    todo_wine ok(!ret, "expected MS Shell Dlg got %s\n", efnd.elf[0].elfLogFont.lfFaceName);
> +    ret = strcmp((char*)efnd.elf[0].elfFullName, "MS Shell Dlg");
> +    ok(ret, "did not expect MS Shell Dlg\n");

Please add the tests for other font enumeration APIs (the may behave
differently), and the tests with NULL face name (according to my tests
in that case MS Shell Dlg won't be enumerated). Since that would clutter
existing tests I'd suggest to move the new one into separate body and
name it appropriately.

-- 
Dmitry.



More information about the wine-devel mailing list