[PATCH 5/8] reg: Add wchar/type conversion functions

Fri Nov 7 06:06:06 CST 2014

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Am 2014-11-06 22:17, schrieb Jonathan Vollebregt:

> +    {REG_NONE, type_none},
An idea for a future test: Test if REG_NONE does anything useful. That's not a blocker for this patch though.

> +static DWORD wchar_get_type(const WCHAR *type_name)
>  {
> ...
> +    for (i = 0; i < ARRAY_SIZE(type_rels); i++)
> +    {
> +        if (!strcmpiW(type_rels[i].name, type_name))
> +            return type_rels[i].type;
> +    }
>  
>      return -1;
>  }
> ...
>         if (reg_type == -1)
Dmitry shout at me, but ~0u would be better since DWORD is unsigned.

If REG_NONE doesn't do anything useful you could use REG_NONE for this purpose. That's just a suggestion though, ~0u is fine for me.