dplayx: Fix some crashes and wine_todo's ( try 2)

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Wed Oct 29 00:31:04 CDT 2014


On 29/10/14 16:19, Nikolay Sivov wrote:
>
>
> On 10/29/2014 08:13 AM, Alistair Leslie-Hughes wrote:
>> +#if 0
>> +    /* Crashes under Win7 */
>>       hr = IDirectPlayX_GetSessionDesc( pDP[0], lpData[0], NULL );
>>       checkHR( DPERR_INVALIDPARAM, hr );
>>       dwDataSize=-1;
>>       hr = IDirectPlayX_GetSessionDesc( pDP[0], lpData[0], &dwDataSize );
>>       checkHR( DPERR_INVALIDPARAMS, hr );
>>       check( -1, dwDataSize );
>> +#endif
>
> That's the same. Wine test use if (0) {} block to disable code. Also you
> don't need checkHR() at all in such cases.
>
We technically don't need checkHR but it does show what was being tested 
for.


Alistair Leslie-Hughes




More information about the wine-devel mailing list