[PATCH v2] loader: check return values of wld_mprotect and wld_mmap calls

Alexandre Julliard julliard at winehq.org
Tue Dec 22 09:59:53 CST 2015


Paul Gofman <gofmanp at gmail.com> writes:

>     Do you think it is better to move return value check directly into
> wld_mmap and wld_mprotect instead of checking their status on call? I
> thought that checking return status rather than building in such an
> effect into system function wrapper is a common approach. Or maybe I
> could add wrapper inline functions with error checking?

It would be better to fix the compiler, or disable the broken
optimization.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list