[PATCH 1/2] wined3d: Try to detect the polygon offset scale value.

Henri Verbeet hverbeet at gmail.com
Thu Jul 30 06:56:47 CDT 2015


On 30 July 2015 at 12:00, Stefan Dösinger <stefan at codeweavers.com> wrote:
> +                if (depth->format_flags & WINED3DFMT_FLAG_FLOAT)
> +                    scale = gl_info->float_polyoffset_scale;
> +                else
> +                    scale = gl_info->fixed_polyoffset_scale;
Ideally this would be a format property. In practice it probably works
because we only use 24 and 32 bit depth formats, and the hardware
probably either only distinguishes between 16 and 24/32, or just
doesn't support 32.

> +    while(1)
I would have preferred that as "for (;;)"

> +    return powf(2, cur);
It seems the compiler is smart enough to work it out, but strictly
speaking powf() takes floating point arguments.



More information about the wine-devel mailing list