[PATCH] kernel32: Return ERROR_CALL_NOT_IMPLEMENTED in GetUserPreferredUILanguages.

Alexandre Julliard julliard at winehq.org
Wed May 27 23:30:16 CDT 2015


Mark Harmstone <hellas at burntcomma.com> writes:

> On 27/05/15 14:12, Alexandre Julliard wrote:
>> Not that it really matters, but I don't see why you'd need to change
>> Wine in order to be able to write a test.
>
> How am I supposed to know if GetUserPreferredUILanguages fails because it's not implemented,
> or fails for some other reason?

That doesn't matter. You are testing the Windows behavior, so unless
there's a Windows version that returns ERROR_CALL_NOT_IMPLEMENTED, you
should never need to check for it.

Once your test succeeds on Windows, you add todo_wine in places where
Wine differs. Whether that's because the function is unimplemented, or
because it's implemented but broken, doesn't make any difference as far
as the test is concerned.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list