msvcp90: basic_string_wchar_dtor should return NULL on i386.
Alexandre Julliard
julliard at winehq.org
Mon Nov 23 09:58:41 CST 2015
Sebastian Lackner <sebastian at fds-team.de> writes:
> On 23.11.2015 13:33, Piotr Caban wrote:
>> Probably the commit message would be more readable if it says:
>> msvcp90: basic_string_wchar_dtor should set EAX to 0 on i386.
>
> EAX is used to store the return value, so both commit messages are
> basically equivalent. If your suggested subject is preferred, I have
> no problem when its changed while applying the patch or to resend
> later.
A comment explaining why we have a destructor that returns a value would
probably also be a good idea.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list