[PATCH 4/5] ddraw: Accept all 3 versions of D3DFINDDEVICERESULT

Henri Verbeet hverbeet at gmail.com
Tue Oct 6 05:01:22 CDT 2015


On 5 October 2015 at 23:24, Andrew D'Addesio <andrew at fatbag.net> wrote:
>>        ok(device > ctx->prev_device, "D3D%d %s enumerated after %s\n", ver,
>>            expected_name, device_list[ctx->prev_device].device_name);
>
> should become:
>
>>        ok(device > ctx->prev_device, "D3D%d %s enumerated after %s\n", ver,
>>           expected_name, device_list[ctx->prev_device].device_name);
>
That should actually just get double indentation as well.

> And I think the other big problem was that I did "enum {" instead of placing
> the { on its own line.
>
Yeah.

> Is there anything else you had in mind that I should know about?
>
You're missing spaces around operators in a couple of places, like
e.g. "2*D3D1_DESC_SIZE".



More information about the wine-devel mailing list