Inconsistent argument type declaration in dinput.h: WriteEffectToFile()

[Elias Vanderstuyft]

On Tue, Sep 22, 2015 at 10:00 PM, Michael Stefaniuc <mstefani at redhat.com> wrote:
> On 09/22/2015 09:32 PM, Elias Vanderstuyft wrote:
>> On Mon, Sep 21, 2015 at 11:06 PM, Marcus Meissner <marcus at jet.franken.de> wrote:
>>> On Mon, Sep 21, 2015 at 10:15:32PM +0200, Elias Vanderstuyft wrote:
>>>> Hi everyone,
>>>>
>>>> The docs of IDirectInputDevice8::WriteEffectToFile() declare the third
>>>> argument as
>>>> LPCDIFILEEFFECT rgDiFileEft:
>>>> https://msdn.microsoft.com/en-us/library/windows/desktop/microsoft.directx_sdk.idirectinputdevice8.idirectinputdevice8.writeeffecttofile%28v=vs.85%29.aspx
>>>> This is inconsistent with Microsoft's "dinput.h" file, they declare it as
>>>> LPDIFILEEFFECT (thus, no "const"):
>>>> ftp://sccn.ucsd.edu/pub/LSL/lsl-dependencies/external_libs/EmbarcaderoXE/shared/4.4.0-msvc/include/dinput.h
>>>> Wine's "dinput.h" follows the same mistake as Microsoft's:
>>>> https://github.com/wine-mirror/wine/blob/master/include/dinput.h#L1866
>>>>
>>>> Is there a particular reason for this?
>>>
>>> No, it was probably missed.
>>>
>>> I am sending a patch.
>>
>> Thanks, I suppose a patch to Wine?
> Yes.
>
>> And leave Microsoft unnotified?
> You can of course notify Microsoft. They might even update MSDN to
> reflect the header.
>
> bye
>         michael

OK, thanks!

Cheers,
Elias