[PATCH v8 1/3] shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.

Sebastian Lackner sebastian at fds-team.de
Mon Aug 22 11:14:49 CDT 2016


On 22.08.2016 18:08, Alex Henrie wrote:
> 2016-08-22 4:15 GMT-06:00 Sebastian Lackner <sebastian at fds-team.de>:
>> I think this patch is unfortunately still a bit too noisy to be applied
>> separately. If you want to keep the "bruteforce" tests I would suggest to
>> move the implementation into the first patch, or alternatively change the
>> FIXME to a TRACE. Besides that I am basically fine, although there are
>> probably some ways how to improve the code style a bit further.
> 
> What if I comment out the "noisy" tests in the first patch and
> uncomment them in the second?
> 
> -Alex
> 

What about aborting the loop after the first failure? This part can then
be removed in the follow up patch.




More information about the wine-devel mailing list