[PATCH v9 2/3] shell32: Implement FolderItems_Item.

[Sebastian Lackner]

On 23.08.2016 06:02, Alex Henrie wrote:
> Cc: Sebastian Lackner <sebastian at fds-team.de>
> 
> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> ---
>  dlls/shell32/shelldispatch.c       | 136 +++++++++++++++++++++++++++++++++++--
>  dlls/shell32/tests/shelldispatch.c |  13 ----
>  2 files changed, 130 insertions(+), 19 deletions(-)
> 

Thanks for the updated version, this already looks much better.
Nevertheless, I have two more small requests:

* You decided to use StrDupW(), but there shouldn't be any need to use
this shlwapi function. The only other place where it was used in
shell32 was wrong and has been fixed with:
http://source.winehq.org/git/wine.git/commit/a11fb74ffb15b60768c6fa49b07251639a6611a6
I would suggest to move the strdupW() function which is used in other
parts of shell32 to the public header file and then use that instead.

* You decided to use exponential growth for the filenames buffer which
is better than allocating only one element at once. Nevertheless, it
might still waste a lot of memory. I would suggest to use either
linear growth or attempt to shrink the buffer size to release
unnecessary space.

Patch 1 should technically be fine, but the code still looks
unnecessary complex to me. I will think about some ways to simplify
it a bit more.

Regards,
Sebastian